Deduplicate tz locations against root #5759
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
robertbastian
requested review from
sffc,
Manishearth,
zbraniecki and
a team
as code owners
robertbastian
force-pushed
the
locations
branch
from
5e0fbb2 to
5209eea
Compare
sffc
approved these changes
Nov 1, 2024
Comment on lines
+550
to
+551
| locations_root: | ||
| <R::ZoneLocations as DateTimeNamesHolderTrait<tz::LocationsV1Marker>>::Container<()>, |
There was a problem hiding this comment.
Thought: This makes DateTimeFormatter<YMDHMSZ> a little bit bigger in stack size.
| time_zone/locations@1, <total>, 1979623B, 1951879B, 204 unique payloads | ||
| time_zone/locations@1, af, 8161B, 8025B, 1cb532d1ca53b263 | ||
| time_zone/locations@1, ak, 8179B, 8043B, 61a5ec381137eb44 | ||
| time_zone/locations@1, <total>, 1435127B, 1407337B, 204 unique payloads |
There was a problem hiding this comment.
Praise: 1'979'623B to 1'435'127B is a big enough improvement that I'm happy landing this despite my other comments.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A lot of location names are the same in many languages.
For exemplar cities we have root data, however for territories we don't. For territories I'm resolving the
undname by using a Latin-script endonym (i.e. for regionXY, resolveund-Latn-XY), and if that fails, just use English (not perfect, but it's better than the raw region code for both display purposes and deduplication).